Custom volume plugin dir #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llndqvst
requested review from
mikhail-sakhnov and
jnummelin
and removed request for
a team
jnummelin
requested changes
Dec 10, 2020
docs/configuration.md
Outdated
| @@ -89,6 +89,7 @@ spec: | |||
| vxlanVNI: 4096 | |||
| mtu: 1450 | |||
| wireguard: false | |||
| flexVolumeDriverPath: /usr/libexec/kubernetes/kubelet-plugins/volume/exec/nodeagent~uds | |||
There was a problem hiding this comment.
I think we should have a explanatory title/item below for this too.
Kubelet already has defaults for this, so this should not be needed. Signed-off-by: Lukas Lindqvist <lukas.lndqvst@gmail.com>
|
I have applied the requested changes. Now the default location should be properly set inside the default kubelet configuration for workers. However, I want to note that this change includes a slight regression from main. Currently k0s checks if the path supplied to I see two possible fixes for this:
|
Signed-off-by: Lukas Lindqvist <lukas.lndqvst@gmail.com>
|
I think the regression from main is acceptable given that customizing the plugin dir should not be needed in most cases. |
jnummelin
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a Pull Request
title: 'Custom volume plugin dir'
labels: ''
assignees: ''
Issue
Fixes #494
What this PR Includes
This PR includes new configuration options to allow the user setting a custom volumePluginDir. Sample configs are also included for getting k0s to work on Fedora CoreOS.