K0s backup #835
Merged
K0s backup #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-sakhnov
force-pushed
the
k0s_backup
branch
2 times, most recently
from
8d3200f to
91e6155
Compare
jnummelin
requested changes
Apr 26, 2021
|
Overall this is good stuff. The only thing on "high-level" I'm bit disliking (and having done some of the work myself, I'm partially to blame too 😄 ) is the fact that we now have to do lot of file/dir copying during the backup and restore. I think it would make sense, at least to try, to rather do "in-place" operations for the various files. Currently this basically means double disk usage for a while for the backup. Might be problematic in resource constrained environments. The above can be refactored, if it's even doable, in a separate PR though. |
mviitane
reviewed
Apr 27, 2021
mikhail-sakhnov
force-pushed
the
k0s_backup
branch
2 times, most recently
from
7e29a60 to
dcd9206
Compare
jnummelin
previously approved these changes
Apr 28, 2021
|
Separate issue to track the kine/sqlite backup capability at #863 |
mikhail-sakhnov
force-pushed
the
k0s_backup
branch
from
09a1cf6 to
3e0e64e
Compare
Signed-off-by: Karen Almog <kalmog@mirantis.com>
Signed-off-by: Karen Almog <kalmog@mirantis.com>
…lated issues Added restore command and smoke test Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
…and deployments after restore Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
… backup-restore process Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
Co-authored-by: Jussi Nummelin <jnummelin@users.noreply.github.com> Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
… link to mkdocs.yml Signed-off-by: Mikhail Sakhnov <msakhnov@mirantis.com>
mikhail-sakhnov
force-pushed
the
k0s_backup
branch
from
3e0e64e to
62b40e9
Compare
jnummelin
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #204
What this PR Includes
This PR adds a
k0s backupcommand that:Task List:
golang:1.15-alpineimage to support cross-compliation of go-sqlite3 (see: Cross compiling fails mattn/go-sqlite3#384)