Inttest/capi clusterclass recreate upgrade #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
force-pushed
the
inttest/capi-clusterclass-recreate-upgrade
branch
from
cb950f4 to
2df93af
Compare
jnummelin
force-pushed
the
inttest/capi-clusterclass-recreate-upgrade
branch
from
2df93af to
8d59645
Compare
|
I think we need to add this test to CI |
Absolutely. For some reason my brain was telling me that if I add it to |
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
force-pushed
the
inttest/capi-clusterclass-recreate-upgrade
branch
from
8d59645 to
be76abb
Compare
apedriza
reviewed
Oct 25, 2024
| err = util.UpdateCluster(s.ctx, s.client, cluster) | ||
| s.Require().NoError(err) | ||
|
|
||
| s.T().Log("waiting for control-plane nodes to be updated") |
There was a problem hiding this comment.
Is it worth checking that the worker nodes are also updated with new version?
apedriza
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CAPI related test for ClusterClass and upgrading a cluster via
ClustertopologyBuilds currently on top of #774 , once that lands I'll rebase. For now look at the last commit only. 😄