Fix machine implementation updating #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhov
force-pushed
the
ownership-fix
branch
13 times, most recently
from
f071ec3 to
425d8fa
Compare
makhov
force-pushed
the
ownership-fix
branch
4 times, most recently
from
1afa11b to
508bdc0
Compare
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
makhov
force-pushed
the
ownership-fix
branch
6 times, most recently
from
34cefdc to
457a0c7
Compare
apedriza
reviewed
Nov 5, 2024
| return nil, err | ||
| } | ||
|
|
||
| resourceType := strings.ToLower(machineFromTemplate.GetKind()) + "s" |
There was a problem hiding this comment.
wdyt about find the apiresource.Name using resource kind and rely on the crd plural?
There was a problem hiding this comment.
Changed it to more reliable way
| RESTConfig *rest.Config | ||
| Scheme *runtime.Scheme | ||
| ClientSet *kubernetes.Clientset | ||
| DynamicClient dynamic.Interface |
There was a problem hiding this comment.
do we need DynamicClient ?
There was a problem hiding this comment.
Not anymore. Removed it, thanks!
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
apedriza
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge and patch existing machine objects to avoid owner conflict and/or admission webhook issues