Failure domains support #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhov
force-pushed
the
failure-domains-support
branch
3 times, most recently
from
8813b6b to
ff0e023
Compare
makhov
force-pushed
the
failure-domains-support
branch
from
ff0e023 to
be74153
Compare
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
makhov
force-pushed
the
failure-domains-support
branch
4 times, most recently
from
2d911e5 to
156bea6
Compare
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
makhov
force-pushed
the
failure-domains-support
branch
from
156bea6 to
7e146b1
Compare
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
apedriza
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #795
The logic is simple: we check
Cluster.status.failureDomainsfield and, if there are any, select the less used one and add it to the machine spec.But it takes some time for the infrastructure controller to publish failure domains, so the reconciliation logic is a bit reordered: we wait for the first controller to start before creating other ones. It should not slow down the overall process of provisioning since we wait for the first controller anyway to be able to create join tokens.
Also, because of this new logic, kubeconfig reconciliation should be done before machine creation.
Tested manually with AWS CAPI infrastructure provider.