Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autopilot wait time #843

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion internal/controller/controlplane/helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,17 @@ func (c *K0sController) createAutopilotPlan(ctx context.Context, kcp *cpv1beta1.
}
if found {
if state == "Schedulable" || state == "SchedulableWait" {
// autopilot is already running
// it is necessary to check if the current autopilot process corresponds to a previous update by comparing the current
// version of the resource with the desired one. If that is the case, the state is not yet ready to proceed with a new plan.
version, found, err := unstructured.NestedString(existingPlan.Object, "spec", "commands", "0", "k0supdate", "version")
if err != nil || !found {
return fmt.Errorf("error getting current autopilot plan's version: %w", err)
}

if version != kcp.Spec.Version {
return fmt.Errorf("previous autopilot is not finished: %w", ErrNotReady)
}

return nil
}
}
Expand Down
Loading