Remove etcdmember that left the cluster #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makhov
force-pushed
the
remove-left-etcdmember
branch
from
4d4989b to
7be926d
Compare
Signed-off-by: Alexey Makhov <amakhov@mirantis.com>
makhov
force-pushed
the
remove-left-etcdmember
branch
from
7be926d to
88b1ebc
Compare
|
I'm a little confused here. Is this change because k0s does soft delete on etcdmembers + we reuse the node names or because of the k0sproject/k0s#5161 bug? If it is the latter could we add some kind of TODO commenting the temporary fix? |
|
Yes, it's because k0s does soft delete and name reuse, but also I just think it's better to clean outdated objects from the cluster in general. |
apedriza
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete old EtcdMember from the cluster after leaving