Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Configurer.CommandExist for sudo without -s #219

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix Configurer.CommandExist for sudo without -s #219

merged 2 commits into from
Aug 7, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Aug 7, 2024

#213 broke linux configurer's CommandExist function when sudo is used. command is a shell internal so something like sudo -- command -v hostname doesn't work.

This wraps the command -v inside /bin/sh -c "command -v ...".

@kke
Fix Configurer.CommandExist for sudo without -s
a75aaf2 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke added the bug Something isn't working label Aug 7, 2024
@kke
Quote further, add test
2dcd432 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke merged commit 7c41ec9 into release-0.x Aug 7, 2024
6 of 7 checks passed
@kke kke deleted the command-exist-fix branch August 7, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kke