Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service environment #40

Merged
merged 1 commit into from
Aug 23, 2021
Merged

fix service environment #40

merged 1 commit into from
Aug 23, 2021

Conversation

erdii
Copy link
Contributor

@erdii erdii commented Aug 19, 2021

  • replace backtick quotes with double quotes in ServiceEnvironmentContent so the trailing \n is translated to a newline
  • always call DaemonReload after updating the service environment file (this is needed for systemd to pick up changes when it previously already knew about the service)

Signed-off-by: erdii me@erdii.engineering

- replace backtick quotes with double quotes in `ServiceEnvironmentContent` so the trailing `\n` is translated to a newline
- always call `DaemonReload` after updating the service environment file (this is needed for systemd to pick up changes when it previously already knew about the service)

Signed-off-by: erdii <me@erdii.engineering>
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kke kke merged commit f9fcf4c into k0sproject:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants