Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix statement type coverage calculation #327

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Fix statement type coverage calculation #327

merged 9 commits into from
Feb 14, 2024

Conversation

furusax0621
Copy link
Contributor

Fix #325

@k1LoW
Copy link
Owner

k1LoW commented Feb 14, 2024

@furusax0621
Fixed govulncheck in main branch

@furusax0621
Copy link
Contributor Author

API rate limit 😢
https://github.com/k1LoW/octocov/actions/runs/7898241942/job/21555315932?pr=327#step:6:101

@k1LoW
Copy link
Owner

k1LoW commented Feb 14, 2024

Please wait a moment 🙏

 gh_test.go:79: GET https://api.github.com/repos/k1LoW/octocov: 403 API rate limit exceeded for installation ID 1750184. If you reach out to GitHub Support for help, please include the request ID B8A9:92DD:BF354D:17F4B38:65CC767D. [rate reset in 21m11s]

@k1LoW k1LoW added the bug Something isn't working label Feb 14, 2024
k1LoW
k1LoW approved these changes Feb 14, 2024
View reviewed changes
Copy link
Owner

@k1LoW k1LoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT! Thank you!!

coverage/merge.go
covered += f.Covered
var fileTotal, fileCovered int

switch f.Type {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@k1LoW k1LoW merged commit 3666661 into k1LoW:main Feb 14, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Merged
@furusax0621 furusax0621 deleted the fix-duplicate-line-count branch February 26, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k1LoW k1LoW k1LoW approved these changes

Assignees
No one assigned
Labels
breaking-change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage calculation results have changed since v0.57.0
2 participants
@furusax0621 @k1LoW