Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification about random combine #452

Merged
merged 13 commits into from
Jun 30, 2022
Merged

Conversation

yaozengwei
Copy link
Collaborator

This PR modifies the random combining of different encoder layers.

  • It combines from 1/3 layers, i.e., layer-4 (counts from 0).
  • It removes linear layers in RandomCombine class.

Experimental results can be found on #431.


mod_inputs.append(inputs[num_inputs - 1])
for i in range(num_inputs):
mod_inputs.append(inputs[i])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need mod_inputs any more?

@pkufool pkufool merged commit d80f29e into k2-fsa:master Jun 30, 2022
@danpovey
Copy link
Collaborator

We have to watch out, here, because this would invalidate already-trained models. If we have uploaded a trained model from this recipe, I suggest we could re-upload a new one.

@yaozengwei
Copy link
Collaborator Author

We have to watch out, here, because this would invalidate already-trained models. If we have uploaded a trained model from this recipe, I suggest we could re-upload a new one.

We have to watch out, here, because this would invalidate already-trained models. If we have uploaded a trained model from this recipe, I suggest we could re-upload a new one.

OK, I will re-upload a new one.

@csukuangfj
Copy link
Collaborator

OK, I will re-upload a new one.

Have you finished uploading the pre-trained models? Please also update RESULTS.md

@@ -1072,7 +1077,6 @@ class RandomCombine(nn.Module):
def __init__(
self,
num_inputs: int,
num_channels: int,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update the test code

@@ -1072,7 +1077,6 @@ class RandomCombine(nn.Module):
def __init__(
self,
num_inputs: int,
num_channels: int,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the following doc:

All but the last input will have a linear transform before we
randomly combine them; these linear transforms will be initialized
to the identity transform.

@yaozengwei
Copy link
Collaborator Author

OK, I will re-upload a new one.

Have you finished uploading the pre-trained models? Please also update RESULTS.md

Thanks for the reminder. See #467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants