Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nodejs-addon-examples): add guide for pnpm user #1401

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

YogiLiu
Copy link
Contributor

@YogiLiu YogiLiu commented Oct 9, 2024

For example, pnpm will install the sherpa-onnx-linux-x64 at node_modules/.pnpm/sherpa-onnx-linux-x64@1.10.27, so the addon.js can not find sherpa-onnx.node.

@csukuangfj
Copy link
Collaborator

pnpm will install the sherpa-onnx-linux-x64 at node_modules/.pnpm/sherpa-onnx-linux-x64@1.10.27

In that case, could you modify

`./node_modules/sherpa-onnx-${platform_arch}/sherpa-onnx.node`,

Does it work if you add

  `./node_modules/.pnpm/sherpa-onnx-${platform_arch}/sherpa-onnx.node`,

@YogiLiu
Copy link
Contributor Author

YogiLiu commented Oct 9, 2024

No, because the folder name with the version like sherpa-onnx-linux-x64@1.10.27.

So alternative way to resolve this issue is parse the installed version of sherpa-onnx-linux-x64, but it is a complicated way.

@YogiLiu
Copy link
Contributor Author

YogiLiu commented Oct 9, 2024

Actually the folder structure like this:

image

@YogiLiu
Copy link
Contributor Author

YogiLiu commented Oct 9, 2024

Update: It is a issue about environment variable LD_LIBRARY_PATH.

YogiLiu added a commit to YogiLiu/read-cat that referenced this pull request Oct 9, 2024
Copy link
Collaborator

@csukuangfj csukuangfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 9765412 into k2-fsa:master Oct 9, 2024
@YogiLiu YogiLiu deleted the docs/pnpm branch October 9, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants