Add streaming ConvEmformer model #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
reviewed
Jul 5, 2022
| @@ -0,0 +1,246 @@ | |||
| # Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang) | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2022 Xiaomi Corp. (authors: Fangjun Kuang) | |
| # Copyright 2022 Xiaomi Corp. (authors: Zengwei Yao) |
csukuangfj
reviewed
Jul 5, 2022
Comment on lines
72
to
73
| auto states_tuple = torch::ivalue::Tuple::create( | ||
| std::get<0>(states), std::get<1>(states)); |
There was a problem hiding this comment.
Suggested change
| auto states_tuple = torch::ivalue::Tuple::create( | |
| std::get<0>(states), std::get<1>(states)); | |
| auto states_tuple = torch::ivalue::Tuple::create( | |
| states.first, states.second); |
is shorter.
pkufool
approved these changes
Jul 6, 2022
Thanks. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements using the streaming ConvEmformer model (See k2-fsa/icefall#440).