relinking after changing route parameters #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k2shah
reviewed
Jun 24, 2021
wadl/survey.py
Outdated
| for task, maze in self.tasks.items(): | ||
| self.solver.setup(maze.graph) | ||
| try: | ||
| solTime = self.solver.solve(routeSet=maze.routeSet) | ||
| maze.solTime = solTime | ||
| # store copy of paths | ||
| self.solvers[maze] = self.solver.copy |
There was a problem hiding this comment.
you can just create a new Solver instance
There was a problem hiding this comment.
I'm a little unsure what you mean here. Wouldn't I lose track of the subPaths and other info then?
There was a problem hiding this comment.
not if you initialize the solver object in the right spot.
self.solver = LinkSolver() is being called on the survey init so you can move that to addTask so that when a task is added a solver for that task/maze is also created in self.solvers
k2shah
added a commit
that referenced
this pull request
Aug 8, 2022
* Mission takeoff fix (#46) * patch for takeoff wp write error * Path tree (#50) * added pathTree subclass * working integrated pathTree * Or export (#51) * exporting some data for OR tools * added at method to survey * clean up on metaTree creation * added timeouut for cvx * switched smt to sat, thanks MK * Kml (#53) * added kml parser to Areas class * Priority Point (#55) * Queue sort (#56) * simple queue sort to avoid islands * syntax shooogar * K2shah patch 1 (#57) * Update python-app.yml * hard coded values are bad * relinking after changing route parameters (#58) * relinking after changing route parameters * guard against small graphs * fixed view with new solver api Co-authored-by: jadenvc <60724399+jadenvc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.