This repository has been archived by the owner on Jun 17, 2020. It is now read-only.
Enable Roslyn Code Analysis #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grant-d
commented
Oct 23, 2017
•
grant-d
commented
- Fixes Enable Roslyn Code Analysis #119 (enable Roslyn FxCopAnalyzers)
- Missing [Flags] in OpenApi
- Comments
- IEquality fixes
- ConfigureAwait
added 2 commits
October 20, 2017 17:23
- Enable Roslyn FxCopAnalyzers - Comments - Equality fixes - ConfigureAwait
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 74.95% 74.52% -0.43%
==========================================
Files 122 122
Lines 5430 5464 +34
==========================================
+ Hits 4070 4072 +2
- Misses 1360 1392 +32
Continue to review full report at Codecov.
|
jcdickinson
suggested changes
Oct 23, 2017
src/SourceCode.Clay/NumberKinds.cs
Outdated
| namespace SourceCode.Clay | ||
| { | ||
| #pragma warning disable S2342 // Enumeration types should comply with a naming convention | ||
| #pragma warning disable S2346 // Flags enumerations zero-value members should be named "None" |
There was a problem hiding this comment.
Don't ignore, add the None.
There was a problem hiding this comment.
There's an existing issue #92 to look at this. I will just remove pragma so we can fix later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.