Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color: black? (Up to now it is white) #14

Closed
guettli opened this issue Sep 14, 2015 · 8 comments
Closed

Background color: black? (Up to now it is white) #14

guettli opened this issue Sep 14, 2015 · 8 comments

Comments

@guettli
Copy link

guettli commented Sep 14, 2015

Most image apps use a black background when images get displayed in fullscreen.

I would prefer black, too.

What do you think?

Why did you choose white?

@MaxLanar
Copy link

MaxLanar commented Oct 3, 2015

I support this request ! :) The possibility to configure that would be great...

@k3b
Copy link
Owner

k3b commented Oct 5, 2015

On my side this ticket has a very low priority because i have outer things in the queue for this hobby project with much higher priority.

May be there is somebody else out there who fixes this:

Todo

@ghost
Copy link

ghost commented Jan 8, 2016

Hello everyone

I really recommend to have a capability to have a Dark Skin and Light Skin, that because Dark Skin will save Battery and that good for everyone. A low energy App is more GreenIT.
For me go to that direction should permit Dark Background.

Then 100% support that feature request ...

@keunes
Copy link
Contributor

keunes commented May 15, 2016

because Dark Skin will save Battery and that good for everyone. A low energy App is more GreenIT. [@Tuuux]

Only for devices with amoled screens, for any of the other screens: no difference.

On my side this ticket has a very low priority because i have outer things in the queue for this hobby project with much higher priority. [@k3b]

I get it. Yet like the OP I would just prefer a black background over a white one. Then colour-picking (I would not only have black & white, but also grey) can be added later as an enhancement.

@k3b
Copy link
Owner

k3b commented Aug 12, 2016

If you find a way to implement backgroundcolor to the PhotoView please send me a merge request to

Unfortunately the original master branch of chrisbanes-PhotoView did not accept the improvements i made for APhotoManager here and here so i keep my own fork

@markusb
Copy link

markusb commented May 2, 2017

Just came here for the background color. I do have quite a few pictures with a dark theme and they are pretty ugly with the white background. But there are some clear pictures too, where a bighter background would be appropriate.

I this the best option is similar to the Philips TV ambilight, where the background adapts to the picture.

While looking at the Photoview app here Baseflow/PhotoView#201 I came across this snippet:

<<uk.co.senab.photoview.PhotoView
android:id="@+id/imgView"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:background="@color/transparent"
android:src="@drawable/image"
/>

This sounds to me to be the way to choose the background color. I may be completely off, though.

@k3b
Copy link
Owner

k3b commented May 17, 2017

blocked: this should wait until #70 implementatino is finished:

Image display is refactored from manuel new PhotoView() to layoutfile

[update 2018-05-14]

#70 is done so this ticket is not blocked any more

@k3b
Copy link
Owner

k3b commented Jan 30, 2020

done with #162

@k3b k3b closed this as completed Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants