Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made themes changeable and some fixes #162

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Made themes changeable and some fixes #162

merged 2 commits into from
Jan 29, 2020

Conversation

vinceh121
Copy link
Contributor

Themes are changeable from the settings view
Various fixes for set values that should be dynamic
Available themes are Holo dark and Holo light

@k3b
Copy link
Owner

k3b commented Jan 9, 2020 •
edited
Loading

Thanks for your contributions.

Merging this change has to wait until architecture re-implementation for android-10 #155 has finished which will take some time. Your change may also become the foundation for solving #14.

@k3b k3b changed the base branch from FDroid to master January 29, 2020 18:43
@k3b k3b merged commit 7b8f6d1 into k3b:master Jan 29, 2020
k3b added a commit that referenced this pull request Jan 30, 2020
@k3b
#162: Fixed Merge Error from themePreference. Recreate Settings after…
dc860d7 
… theme change
k3b added a commit that referenced this pull request Jan 30, 2020
@k3b
#162: Fixed Merge Error; Refactored Theme code to UserTheme.java; THe…
20963c0 
…me-change takes immediate effect
k3b added a commit that referenced this pull request Jan 30, 2020
@k3b
#162: reimplemented: calculation themeResID
fc97526
@k3b k3b mentioned this pull request Jan 30, 2020
Closed
@k3b
Copy link
Owner

k3b commented Jan 30, 2020

@vinceh121 : your featue is now integrated into the app. Thanks a lot.
I made some small changes:

  • code moved from GuiUtils.java to the new class UserThemes.
  • Settings Activity will show current theme name
  • Making theme changes in the settingsActivity will immediately change the thems of all open activities

k3b added a commit that referenced this pull request Feb 6, 2020
@k3b
#162: #21: Added all Translations for Theme support
ec98aa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beauty enhancement mod settings usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinceh121 @k3b