Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont replace kubeconfig symlink by a file at cluster creation #1455

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: dont replace kubeconfig symlink by a file at cluster creation #1455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/client/kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,12 +283,22 @@ func KubeconfigWrite(ctx context.Context, kubeconfig *clientcmdapi.Config, path
return fmt.Errorf("failed to write merged kubeconfig to temporary file '%s': %w", tempPath, err)
}

// In case path is a symlink, retrives the name of the target
realPath, err := filepath.EvalSymlinks(path)
if err != nil {
return fmt.Errorf("failed to follow symlink '%s': %w", path, err)
}

// Move temporary file over existing KubeConfig
if err := os.Rename(tempPath, path); err != nil {
if err := os.Rename(tempPath, realPath); err != nil {
return fmt.Errorf("failed to overwrite existing KubeConfig '%s' with new kubeconfig '%s': %w", path, tempPath, err)
}

l.Log().Debugf("Wrote kubeconfig to '%s'", path)
extraLog := ""
if filepath.Clean(path) != realPath {
extraLog = fmt.Sprintf("(via symlink '%s')", path)
}
l.Log().Debugf("Wrote kubeconfig to '%s' %s", realPath, extraLog)

return nil
}
Expand Down
Loading