Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Basic Plugin System - SubGoal: callables #333

Merged
merged 2 commits into from
Sep 14, 2020
Merged

[Feature] Basic Plugin System - SubGoal: callables #333

merged 2 commits into from
Sep 14, 2020

Conversation

iwilltry42
Copy link
Member

@iwilltry42 iwilltry42 commented Aug 13, 2020 •
edited
Loading

What?

This PR is highly inspired by the kubectl plugin system.
When you try to run a subcommand which is not part of the default k3d command tree, k3d will try to find an executable with that name in your PATH and execute it (based on the longest possible prefix).
Example:

  • k3d test-plugin
    • executable must be in PATH and named k3d-test_plugin

Test

References

@iwilltry42 iwilltry42 added the enhancement New feature or request label Aug 13, 2020
@iwilltry42 iwilltry42 added this to the 3.1.0 milestone Aug 13, 2020
@iwilltry42 iwilltry42 self-assigned this Aug 13, 2020
@iwilltry42 iwilltry42 mentioned this pull request Aug 13, 2020
Open
@iwilltry42 iwilltry42 changed the title [Feature] Basic Plugin System [Feature] Basic Plugin System - SubGoal: callables Aug 19, 2020
sgandon
sgandon approved these changes Sep 8, 2020
View reviewed changes
Copy link

@sgandon sgandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwilltry42 iwilltry42 merged commit ddbf019 into main Sep 14, 2020
rancherio-gh-m pushed a commit that referenced this pull request Sep 14, 2020
@iwilltry42
commit ddbf019
4c09003 
Merge: 2d2713a fb0d095
Author: Thorsten Klein <iwilltry42@gmail.com>
Date:   Mon Sep 14 08:42:08 2020 +0200

    Merge pull request #333 from rancher/feature/plugin-system

    [Feature] Basic Plugin System - SubGoal: callables
@iwilltry42 iwilltry42 deleted the feature/plugin-system branch June 22, 2021 18:34
@FedericoAntoniazzi FedericoAntoniazzi mentioned this pull request Aug 18, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgandon sgandon sgandon approved these changes

@ibuildthecloud ibuildthecloud Awaiting requested review from ibuildthecloud

@cjellick cjellick Awaiting requested review from cjellick

Assignees

@iwilltry42 iwilltry42

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iwilltry42 @sgandon