Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enhanced k3d-proxy configuration #638

Merged
merged 16 commits into from
Jun 22, 2021

Conversation

iwilltry42
Copy link
Member

@iwilltry42 iwilltry42 commented Jun 17, 2021

This is a preparation to more easily allow for updating port mappings on a running cluster.
More details will follow.

Preliminary & Incomplete Changelog

  • k3d-proxy / serverlb
    • updated confd template for nginx, now based on a yaml file injected just before container startup (or at runtime)
    • updated confd version (custom fork) to use -watch so we don't need to issue confd -onetime and nginx -s reload anymore when updating the config
  • revamped loadbalancer creation + update procedure
  • NodeHooks are now part of the Node type struct, so they don't get lost underways
  • defaults for helper images + ability to set them from env separately

To-Dos

  • Properly update the loadbalancer when new nodes are added (as we have it now)
  • adapt new node edit --port-add functionality to new loadbalancer config file
  • when nodes are added and the lb config updated, ensure that the lb is still fine (could break due to broken upstreams)

Follow-Up Issues

  • NodeDelete: success message at the end (i.e. also after updating the LB)
  • NodeCreate/NodeDelete: single collective update of the loadbalancer
    • only, when nodes are up and running

@iwilltry42 iwilltry42 added this to the v5.0.0 milestone Jun 18, 2021
@iwilltry42 iwilltry42 self-assigned this Jun 18, 2021
@iwilltry42 iwilltry42 marked this pull request as ready for review June 21, 2021 19:01
@iwilltry42 iwilltry42 merged commit 853780e into main-v5 Jun 22, 2021
@iwilltry42 iwilltry42 deleted the feature/enhanced-proxy-config branch June 22, 2021 18:31
@iwilltry42 iwilltry42 mentioned this pull request Jun 22, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant