Refactor controllers to separate package, shift cli-runtime to wrangler-cli, introduce pprof options #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
from
8b7ea58
to
6ef8ac5
Compare
|
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
from
e5cfb4e
to
c1ed8a0
Compare
brandond
requested changes
Sep 7, 2022
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
3 times, most recently
from
a1df6b4
to
0954cd8
Compare
arvindiyengar: ~/Rancher/helm-controller/src/github.com/k3s-io/helm-controller
$ ./helm-controller --help
Usage:
helm-controller [flags]
Flags:
--debug Turn on debug logging
--debug-level int If debugging is enabled, set klog -v=X
-h, --help help for helm-controller
-k, --kubeconfig string Kubernetes config files, e.g. $HOME/.kube/config
-m, --master-url string Kubernetes cluster master URL
-n, --namespace string Namespace to watch, empty means it will watch CRDs in all namespaces.
--pprof-port int Port to publish HTTP server runtime profiling data in the format expected by the pprof visualization tool. Only enabled if in debug mode (default 6060)
-t, --threads int Threadiness level to set, defaults to 2. (default 2)
-v, --version version for helm-controllerpprof stuff has been added and moved to be entirely self-contained in a single commit. |
aiyengar2
changed the title
added 2 commits
September 7, 2022 17:05
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
from
0954cd8
to
db191fc
Compare
brandond
requested changes
Sep 8, 2022
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com> (cherry picked from commit e8b0e5a)
brandond
requested changes
Sep 8, 2022
pkg/controllers/controllers.go
Outdated
Comment on lines
52
to
54
| if len(systemNamespace) == 0 { | ||
| return errors.New("cannot start controllers on system namespace: system namespace not provided") | ||
| } |
There was a problem hiding this comment.
We throw an error here if systemNamespace is empty, but down below at https://github.com/k3s-io/helm-controller/pull/157/files#diff-b32dd54d2bd7ecc467b19203287df80c4c1e3934ea80602aadd6658306b5cca6R73 it looks like the intent was to allow for watching all namespaces if the string is empty. Is this an error, or should that subsequent check be removed?
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
from
28433d3
to
dd785ff
Compare
added 2 commits
September 7, 2022 17:47
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com> (cherry picked from commit db20eff) Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
Signed-off-by: Arvind Iyengar <arvind.iyengar@rancher.com>
aiyengar2
force-pushed
the
refactor_controllers_logic_and_cli_runtime
branch
from
8ecacf6
to
233b031
Compare
brandond
approved these changes
Sep 8, 2022
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 5 of #141