Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security exposure related to the token #356

Merged
merged 2 commits into from
Sep 4, 2024

Commits on Aug 22, 2024

  1. Security exposure related to the token

    The installation playbook saves the token into the systemd unit
    configuration file /etc/systemd/system/k3s.service. The problem is that
    according to K3s' documentation "the server token should be guarded
    carefully" (https://docs.k3s.io/cli/token), yet the configuration file
    is readable by anybody. A better solution is to save the token into its
    corresponding environment file /etc/systemd/system/k3s.service.env which
    is readable by the super user only. This is what the standard K3s'
    installation script (https://get.k3s.io) does.
    
    Signed-off-by: Marko Vukovic <8951449+anon-software@users.noreply.github.com>
    anon-software committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    30c38a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Restore the server URL into systemd configuration file

    There aren't any security implications in keeping it there.
    
    Signed-off-by: Marko Vukovic <8951449+anon-software@users.noreply.github.com>
    anon-software committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7230e32 View commit details
    Browse the repository at this point in the history