Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: busybox 1.34.1 #50

Merged
merged 1 commit into from
Dec 18, 2021
Merged

bump: busybox 1.34.1 #50

merged 1 commit into from
Dec 18, 2021

Conversation

dweomer
Copy link
Contributor

@dweomer dweomer commented Dec 11, 2021

This diverges from buildroot LTS but it has some security fixes.

Signed-off-by: Jacob Blain Christen jacob@rancher.com

@dweomer
bump: busybox 1.34.1
a61f622 
This diverges from buildroot LTS but it has some security fixes.

Signed-off-by: Jacob Blain Christen <jacob@rancher.com>
Oats87
Oats87 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@Oats87 Oats87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane to me; however, as always, I'm worried about potential regressions introduced through changing busybox which is like 90% of the binaries in k3s-root

brandond
brandond approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@brandond brandond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; curious what you end up doing with wrappers for selinux purposes.

@dweomer dweomer merged commit f33d625 into k3s-io:master Dec 18, 2021
@dweomer dweomer deleted the bump/busybox/1.34.1 branch December 18, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@Oats87 Oats87 Oats87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweomer @brandond @Oats87