-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests.sh, shellcheck and fix compare_versions #70
Conversation
This commits adds the tests.sh file with unit tests for helper functions in upgrade.sh Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
Long term I would like to make this script consistent about using ${FOO}
instead of $FOO for everything but positional arguments ($1
and so on) - right now we alternate between the two for no particular reason. But we don't need to fix that now.
9d888e8
to
8f4fdd1
Compare
Busybox likely lacks the necessary libraries to support the |
See actions/checkout#334 (comment), where it was discussed. its possible they fixed this in v3, but maybe not. |
dd95cae
to
7cff4cf
Compare
80fd0d9
to
ee2e189
Compare
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
This commits adds the tests.sh file with unit tests for helper functions in upgrade.sh, fix some shellcheck warnings