Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests.sh, shellcheck and fix compare_versions #70

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

osodracnai
Copy link
Contributor

This commits adds the tests.sh file with unit tests for helper functions in upgrade.sh, fix some shellcheck warnings

This commits adds the tests.sh file with unit tests for helper functions in upgrade.sh

Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
@osodracnai osodracnai marked this pull request as ready for review July 25, 2023 17:32
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

Long term I would like to make this script consistent about using ${FOO} instead of $FOO for everything but positional arguments ($1 and so on) - right now we alternate between the two for no particular reason. But we don't need to fix that now.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
scripts/upgrade.sh Outdated Show resolved Hide resolved
scripts/upgrade.sh Outdated Show resolved Hide resolved
scripts/upgrade.sh Outdated Show resolved Hide resolved
@osodracnai osodracnai force-pushed the add-tests branch 3 times, most recently from 9d888e8 to 8f4fdd1 Compare July 25, 2023 18:36
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@dereknola
Copy link
Member

Busybox likely lacks the necessary libraries to support the checkout action, so you may need to manually craft a git clone command for it. Or, checkout the repo in a previous step on the ubuntu host, then store them as artifacts and have busybox pull those down in the next stage. See https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts

@dereknola
Copy link
Member

See actions/checkout#334 (comment), where it was discussed. its possible they fixed this in v3, but maybe not.

@osodracnai osodracnai force-pushed the add-tests branch 3 times, most recently from dd95cae to 7cff4cf Compare July 25, 2023 18:56
scripts/upgrade.sh Outdated Show resolved Hide resolved
@osodracnai osodracnai force-pushed the add-tests branch 7 times, most recently from 80fd0d9 to ee2e189 Compare July 25, 2023 19:36
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
@osodracnai osodracnai merged commit adfb2fc into k3s-io:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants