Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kine to v0.11.9 to fix pagination #10082

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented May 9, 2024

Proposed Changes

Bump kine to v0.11.9 to fix pagination

Types of Changes

bugfix, version bump

Verification

See linked issue

  1. Start k3s:
    k3s server --kube-apiserver-arg=feature-gates=WatchList=true --disable=coredns,servicelb,traefik,local-storage,metrics-server --disable-network-policy
  2. Run conformance tests:
    docker run --rm -it -v "$KUBECONFIG:/root/.kube/config" -e "KUBECONFIG=/root/.kube/config" -e "E2E_EXTRA_ARGS=--ginkgo.fail-fast" -e "E2E_FOCUS=sig-api-machinery" -e "E2E_SKIP=StorageVersionAPI|Slow|Flaky" registry.k8s.io/conformance:$(kubectl get --raw /version | grep gitVersion | grep -Eo 'v[0-9]+\.[0-9]+\.[0-9]+')

StorageVersionAPI is broken and not graduating beyond alpha. One of the slow tests has a timeout that relies on specific etcd compaction intervals that kine doesn't guarantee, this is fine. The flaky test... is flaky and fails about half the time.

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner May 9, 2024 19:06
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.63%. Comparing base (1454953) to head (47cff43).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10082      +/-   ##
==========================================
- Coverage   47.80%   41.63%   -6.17%     
==========================================
  Files         173      173              
  Lines       14645    14645              
==========================================
- Hits         7001     6098     -903     
- Misses       6313     7384    +1071     
+ Partials     1331     1163     -168     
Flag Coverage Δ
e2etests 36.39% <ø> (-10.11%) ⬇️
inttests 19.80% <ø> (ø)
unittests 11.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants