Replace deprecated ruby function in e2e tests #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Buil <mbuil@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10084 +/- ##
==========================================
- Coverage 47.77% 41.79% -5.98%
==========================================
Files 173 173
Lines 14645 14645
==========================================
- Hits 6996 6121 -875
- Misses 6317 7362 +1045
+ Partials 1332 1162 -170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
May 10, 2024
dereknola
approved these changes
May 10, 2024
This was referenced May 13, 2024
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Jun 5, 2024
#4770) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [k3s-io/k3s](https://togithub.com/k3s-io/k3s) | patch | `v1.30.0+k3s1` -> `v1.30.1+k3s1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>k3s-io/k3s (k3s-io/k3s)</summary> ### [`v1.30.1+k3s1`](https://togithub.com/k3s-io/k3s/releases/tag/v1.30.1%2Bk3s1): v1.30.1+k3s1 [Compare Source](https://togithub.com/k3s-io/k3s/compare/v1.30.0+k3s1...v1.30.1+k3s1) <!-- v1.30.1+k3s1 --> This release updates Kubernetes to v1.30.1, and fixes a number of issues. For more details on what's new, see the [Kubernetes release notes](https://togithub.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md#changelog-since-v1300). ##### Changes since v1.30.0+k3s1: - Replace deprecated ruby function in e2e tests [(#​10084)](https://togithub.com/k3s-io/k3s/pull/10084) - Update channels with 1.30 [(#​10097)](https://togithub.com/k3s-io/k3s/pull/10097) - Address 461 [(#​10112)](https://togithub.com/k3s-io/k3s/pull/10112) - Update to v1.30.1-k3s1 and Go 1.22.2 [(#​10105)](https://togithub.com/k3s-io/k3s/pull/10105) ##### Embedded Component Versions | Component | Version | |---|---| | Kubernetes | [v1.30.1](https://togithub.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md#v1301) | | Kine | [v0.11.8-0.20240430184817-f9ce6f8da97b](https://togithub.com/k3s-io/kine/releases/tag/v0.11.8-0.20240430184817-f9ce6f8da97b) | | SQLite | [3.44.0](https://sqlite.org/releaselog/3\_44\_0.html) | | Etcd | [v3.5.9-k3s1](https://togithub.com/k3s-io/etcd/releases/tag/v3.5.9-k3s1) | | Containerd | [v1.7.15-k3s1](https://togithub.com/k3s-io/containerd/releases/tag/v1.7.15-k3s1) | | Runc | [v1.1.12-k3s1](https://togithub.com/opencontainers/runc/releases/tag/v1.1.12-k3s1) | | Flannel | [v0.24.2](https://togithub.com/flannel-io/flannel/releases/tag/v0.24.2) | | Metrics-server | [v0.7.0](https://togithub.com/kubernetes-sigs/metrics-server/releases/tag/v0.7.0) | | Traefik | [v2.10.7](https://togithub.com/traefik/traefik/releases/tag/v2.10.7) | | CoreDNS | [v1.10.1](https://togithub.com/coredns/coredns/releases/tag/v1.10.1) | | Helm-controller | [v0.16.1-0.20240502205943-2f32059d43e6](https://togithub.com/k3s-io/helm-controller/releases/tag/v0.16.1-0.20240502205943-2f32059d43e6) | | Local-path-provisioner | [v0.0.26](https://togithub.com/rancher/local-path-provisioner/releases/tag/v0.0.26) | ##### Helpful Links As always, we welcome and appreciate feedback from our community of users. Please feel free to: - [Open issues here](https://togithub.com/rancher/k3s/issues/new/choose) - [Join our Slack channel](https://slack.rancher.io/) - [Check out our documentation](https://rancher.com/docs/k3s/latest/en/) for guidance on how to get started or to dive deep into K3s. - [Read how you can contribute here](https://togithub.com/rancher/k3s/blob/master/CONTRIBUTING.md) ##### What's Changed - Replace deprecated ruby function in e2e tests by [@​manuelbuil](https://togithub.com/manuelbuil) in [https://github.com/k3s-io/k3s/pull/10084](https://togithub.com/k3s-io/k3s/pull/10084) - Update channels with 1.30 by [@​galal-hussein](https://togithub.com/galal-hussein) in [https://github.com/k3s-io/k3s/pull/10097](https://togithub.com/k3s-io/k3s/pull/10097) - Address 461 by [@​HarrisonWAffel](https://togithub.com/HarrisonWAffel) in [https://github.com/k3s-io/k3s/pull/10112](https://togithub.com/k3s-io/k3s/pull/10112) - Update to v1.30.1-k3s1 and Go 1.22.2 by [@​briandowns](https://togithub.com/briandowns) in [https://github.com/k3s-io/k3s/pull/10105](https://togithub.com/k3s-io/k3s/pull/10105) **Full Changelog**: k3s-io/k3s@v1.30.0+k3s1...v1.30.1+k3s1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zODEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM4MS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
existswas deprecated since ruby 2.1 and removed in ruby 3.2:https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/
Types of Changes
Bugfix
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
Thanks @mgfritch