Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.29] Fix bug when using tailscale config by file #10142

Merged
merged 1 commit into from
May 24, 2024

Conversation

manuelbuil
Copy link
Contributor

Backport: #10074
Issue: #10139

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner May 23, 2024 10:01
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 24.90%. Comparing base (4e53a32) to head (d64d50d).

Files Patch % Lines
pkg/cli/agent/agent.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.29   #10142       +/-   ##
=================================================
- Coverage         50.12%   24.90%   -25.22%     
=================================================
  Files               158      158               
  Lines             14038    14038               
=================================================
- Hits               7036     3496     -3540     
- Misses             5671     9851     +4180     
+ Partials           1331      691      -640     
Flag Coverage Δ
e2etests 4.88% <0.00%> (-41.80%) ⬇️
inttests 18.98% <0.00%> (-18.16%) ⬇️
unittests 16.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit 86ad488 into k3s-io:release-1.29 May 24, 2024
27 checks passed
@manuelbuil manuelbuil deleted the issue-10064_release-1.29 branch May 24, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants