Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flannel version to v0.25.2 #10146

Merged
merged 2 commits into from
May 28, 2024

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented May 23, 2024

Proposed Changes

Update flannel to v0.25.2.

The iptables package was refactored in upstream flannel so we need some changes in flannel.go to keep track of it.

Types of Changes

Version Update

Verification

Testing

Linked Issues

#9957

@thomasferrandiz thomasferrandiz requested a review from a team as a code owner May 23, 2024 15:53
@thomasferrandiz thomasferrandiz marked this pull request as draft May 23, 2024 16:02
@thomasferrandiz thomasferrandiz force-pushed the flannel-v0.25.2 branch 2 times, most recently from 686729b to 90eb0b0 Compare May 24, 2024 09:48
@thomasferrandiz thomasferrandiz marked this pull request as ready for review May 24, 2024 09:48
rbrtbnfgl
rbrtbnfgl previously approved these changes May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 41.57%. Comparing base (aadec85) to head (6dcd52e).
Report is 6 commits behind head on master.

Files Patch % Lines
pkg/agent/flannel/flannel.go 48.71% 10 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10146      +/-   ##
==========================================
- Coverage   48.01%   41.57%   -6.45%     
==========================================
  Files         173      173              
  Lines       14658    14668      +10     
==========================================
- Hits         7038     6098     -940     
- Misses       6288     7394    +1106     
+ Partials     1332     1176     -156     
Flag Coverage Δ
e2etests 36.30% <48.71%> (-10.30%) ⬇️
inttests 19.79% <0.00%> (-17.18%) ⬇️
unittests 11.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dereknola
dereknola previously approved these changes May 24, 2024
pkg/agent/flannel/flannel.go Outdated Show resolved Hide resolved
pkg/agent/flannel/flannel.go Outdated Show resolved Hide resolved
pkg/agent/flannel/flannel.go Outdated Show resolved Hide resolved
pkg/agent/flannel/flannel.go Outdated Show resolved Hide resolved
pkg/agent/flannel/flannel.go Show resolved Hide resolved
pkg/agent/flannel/flannel.go Show resolved Hide resolved
brandond
brandond previously approved these changes May 27, 2024
Signed-off-by: Thomas Ferrandiz <thomas.ferrandiz@suse.com>
Signed-off-by: Thomas Ferrandiz <thomas.ferrandiz@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants