Fix embedded mirror blocked by SAR RBAC and re-enable test #10257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
fix-embedded-mirror
branch
from
5d35945
to
dc243de
Compare
dereknola
previously approved these changes
May 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10257 +/- ##
==========================================
- Coverage 47.79% 41.61% -6.19%
==========================================
Files 177 177
Lines 14772 14775 +3
==========================================
- Hits 7061 6149 -912
- Misses 6364 7448 +1084
+ Partials 1347 1178 -169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-embedded-mirror
branch
from
dc243de
to
a735911
Compare
briandowns
approved these changes
May 30, 2024
vitorsavian
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix embedded mirror blocked by SAR RBAC and re-enable test.
The embedded registry mirror was broken by #10019 - requests to the registry API are being run rejected by authz subject access reviews when they should not be. This is due to the AlwaysAllowPaths being incorrectly configured to match specific paths instead of prefixes.
Types of Changes
bugfix
Verification
see linked issue
Testing
Linked Issues
User-Facing Change
Further Comments