[release-1.29] More backports for 2024-06 release cycle #10288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Bump Local Path Provisioner version Made with ❤️️ by updatecli (cherry picked from commit 1268779) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Koen de Laat <koen.de.laat@philips.com> (cherry picked from commit 79ba10f) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
If proxy.SetAPIServerPort was called multiple times, all calls after the first one would cause the apiserver address to be set to the default server address, bypassing the local load-balancer. This was most likely to occur on RKE2, where the supervisor may be up for a period of time before it is ready to manage node password secrets, causing the agent to retry. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 1661f10) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
VestigeJ
approved these changes
Jun 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.29 #10288 +/- ##
================================================
- Coverage 49.75% 43.26% -6.49%
================================================
Files 163 163
Lines 14195 14204 +9
================================================
- Hits 7063 6146 -917
- Misses 5788 6880 +1092
+ Partials 1344 1178 -166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Backports:
Types of Changes
Verification
Testing
See linked issues
Linked Issues
User-Facing Change
Further Comments