Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport 1.27]Add test for isValidResolvConf (#10302) #10332

Merged

Conversation

fmoral2
Copy link
Contributor

@fmoral2 fmoral2 commented Jun 7, 2024

(cherry picked from commit 043b1ea)

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Francisco <francisco.moral@suse.com>
(cherry picked from commit 043b1ea)
Signed-off-by: Francisco <francisco.moral@suse.com>
@fmoral2 fmoral2 requested a review from a team as a code owner June 7, 2024 12:22
@fmoral2 fmoral2 changed the title Add test for isValidResolvConf (#10302) [backport 1.27]Add test for isValidResolvConf (#10302) Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.33%. Comparing base (88c20d8) to head (652ffaa).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27   #10332      +/-   ##
================================================
- Coverage         42.89%   33.33%   -9.57%     
================================================
  Files               163      160       -3     
  Lines             16531    13957    -2574     
================================================
- Hits               7091     4652    -2439     
- Misses             8185     8379     +194     
+ Partials           1255      926     -329     
Flag Coverage Δ
e2etests 33.33% <ø> (-12.83%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmoral2 fmoral2 merged commit 6d6cf86 into k3s-io:release-1.27 Jun 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants