Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent supervisor port using apiserver port instead #10352

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix agent supervisor port using apiserver port instead

The agent's supervisor listener on RKE2 is using the wrong port. Didn't notice it here because they're the same in k3s.

Types of Changes

bugfix

Verification

Can only be tested in RKE2

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner June 13, 2024 20:28
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.77%. Comparing base (f10cb29) to head (df39266).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/agent/https/https.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10352      +/-   ##
==========================================
- Coverage   41.78%   41.77%   -0.01%     
==========================================
  Files         177      177              
  Lines       14806    14807       +1     
==========================================
  Hits         6186     6186              
  Misses       7443     7443              
- Partials     1177     1178       +1     
Flag Coverage Δ
e2etests 36.48% <50.00%> (+0.39%) ⬆️
inttests 36.94% <50.00%> (-0.07%) ⬇️
unittests 11.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit b4d4ed8 into k3s-io:master Jun 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants