Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] Backports for 2024-08 release cycle #10666

Merged

Conversation

brandond and others added 8 commits August 2, 2024 20:49
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit c2216a6)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Make secretsencrypt page size and iteration consistent with other paginators

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 891e72f)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 21611c5)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This is a partial revert of 095ecdb,
with the workaround moved into klipper-lb.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit d4c3422)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Will <will7989@hotmail.com>
(cherry picked from commit e4f3cc7)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Co-authored-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Will Andrews <will7989@hotmail.com>
(cherry picked from commit e2179aa)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit e168438)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Looking at metrics revealed the cloudprovider controller name was anempty string.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit bffdf46)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner August 2, 2024 21:01
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 35.90%. Comparing base (7f80d18) to head (bca5cb8).
Report is 1 commits behind head on release-1.28.

Files Patch % Lines
pkg/etcd/snapshot.go 0.00% 18 Missing ⚠️
pkg/secretsencrypt/controller.go 0.00% 14 Missing ⚠️
pkg/etcd/snapshot_controller.go 0.00% 10 Missing ⚠️
pkg/cloudprovider/servicelb.go 43.75% 8 Missing and 1 partial ⚠️
pkg/cluster/cluster.go 0.00% 1 Missing ⚠️
pkg/cluster/managed.go 0.00% 1 Missing ⚠️
pkg/cluster/storage.go 66.66% 1 Missing ⚠️
pkg/etcd/etcd.go 0.00% 1 Missing ⚠️
pkg/spegel/bootstrap.go 0.00% 1 Missing ⚠️
pkg/spegel/spegel.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7f80d18) and HEAD (bca5cb8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7f80d18) HEAD (bca5cb8)
e2etests 7 6
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.28   #10666       +/-   ##
=================================================
- Coverage         45.93%   35.90%   -10.03%     
=================================================
  Files               162      162               
  Lines             14179    14196       +17     
=================================================
- Hits               6513     5097     -1416     
- Misses             6373     8109     +1736     
+ Partials           1293      990      -303     
Flag Coverage Δ
e2etests 35.90% <25.00%> (-10.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 199d9ea into k3s-io:release-1.28 Aug 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants