Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.30] Backports for August 2024 #10671

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 5, 2024

Proposed Changes

Backports:

Types of Changes

Verification

Testing

Linked Issues

#10633
#10637

User-Facing Change


Further Comments

* Remove unnecessary hardened arguments

Signed-off-by: Derek Nola <derek.nola@suse.com>

* slim down hardened arguments

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
* Use higher QPS for secrets reencryption

Signed-off-by: Derek Nola <derek.nola@suse.com>
* Allow pprof to run on server with `--disable-agent`
* Allow supervisor metrics to run on server with `--disable-agent`

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner August 5, 2024 17:05
@dereknola dereknola changed the title Backports for August 2024 [Release-1.30] Backports for August 2024 Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 26.57%. Comparing base (7190c74) to head (11d183f).

Files Patch % Lines
pkg/agent/run.go 0.00% 4 Missing and 2 partials ⚠️
pkg/secretsencrypt/controller.go 0.00% 6 Missing ⚠️
pkg/daemons/control/server.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7190c74) and HEAD (11d183f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7190c74) HEAD (11d183f)
e2etests 6 5
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.30   #10671       +/-   ##
=================================================
- Coverage         47.39%   26.57%   -20.83%     
=================================================
  Files               179      179               
  Lines             14948    14955        +7     
=================================================
- Hits               7085     3974     -3111     
- Misses             6568    10236     +3668     
+ Partials           1295      745      -550     
Flag Coverage Δ
e2etests 5.01% <0.00%> (-37.69%) ⬇️
inttests 19.70% <0.00%> (-17.01%) ⬇️
unittests 13.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 6965b5d into k3s-io:release-1.30 Aug 6, 2024
29 checks passed
@dereknola dereknola deleted the slim_hard_130 branch August 12, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants