Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.29] Fix hosts.toml header var #10873

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Resolves issue from 270f85e that prevented old hosts.toml files from being cleaned up.

Types of Changes

bugfix

Verification

See linked isse

Testing

Linked Issues

User-Facing Change


Further Comments

Resolves issue from 270f85e that prevented old hosts.toml files from being cleaned up.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner September 10, 2024 19:16
@brandond brandond changed the title Fix hosts.toml header var [release-1.29] Fix hosts.toml header var Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.41%. Comparing base (17201d4) to head (5596e10).
Report is 1 commits behind head on release-1.29.

❗ There is a different number of reports uploaded between BASE (17201d4) and HEAD (5596e10). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (17201d4) HEAD (5596e10)
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #10873      +/-   ##
================================================
- Coverage         49.26%   43.41%   -5.85%     
================================================
  Files               178      178              
  Lines             14924    14924              
================================================
- Hits               7352     6480     -872     
- Misses             6232     7250    +1018     
+ Partials           1340     1194     -146     
Flag Coverage Δ
e2etests 36.20% <ø> (-9.90%) ⬇️
inttests 36.81% <ø> (+17.08%) ⬆️
unittests 13.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0dfad66 into k3s-io:release-1.29 Sep 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants