Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go.mod): update go-sql-driver/mysql version to v1.8.1 #10914

Closed

Conversation

mayooot
Copy link

@mayooot mayooot commented Sep 19, 2024

An error occurs when use k3s server --datastore-endpoint='mysql://root:root@tcp(localhost:3306)/foo%2Fbar' is used to create k3s.

Because the go-sql-driver version used by k3s is earlier than v1.8.0, Refer to README.md.

For more information, loft-sh/vcluster#2152

@mayooot mayooot requested a review from a team as a code owner September 19, 2024 08:36
@lucasfcnunes
Copy link

Fixes loft-sh/vcluster#2152.

@lucasfcnunes
Copy link

@mayooot You have commits missing the message Signed-off-by: Author Name <authoremail@example.com>. To sign, always commit with git commit -s -m '...'.

To rebase sign the last already committed:

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin feat/update-go-sql-driver-version

Signed-off-by: Harry Li <bertram_li@163.com>
@mayooot mayooot force-pushed the feat/update-go-sql-driver-version branch from 6c554d4 to 6799a02 Compare September 19, 2024 15:10
@mayooot
Copy link
Author

mayooot commented Sep 19, 2024

@lucasfcnunes thanks a lot!

@brandond
Copy link
Member

This module should be bumped on the Kine side first. We can bump this here once that is done.

@brandond
Copy link
Member

Closing, will be updated when kine is updated.

@brandond brandond closed this Sep 30, 2024
@lucasfcnunes
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants