Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user path to runtimes search #10953

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Sep 26, 2024

Proposed Changes

  • Use the runtimes default paths and the user path when searching for the runtimes

Types of Changes

  • Feature

Verification

  • Change the path
export PATH=/home/ubuntu:$PATH
  • Add a binary in the /home/ubuntu
touch nvidia-container-runtime && chmod +x nvidia-container-runtime
  • Run k3s
k3s server
  • Cat the config.toml and grep the runtime
cat /var/lib/rancher/k3s/agent/etc/containerd/config.toml | grep "nvidia-container-runtime"

Testing

Linked Issues

User-Facing Change

Runtimes detection will now use $PATH

Further Comments

  • I think this will be a good idea, since we will also detect runtimes in the entire user path

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner September 26, 2024 16:22
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.24%. Comparing base (ed14f7f) to head (c5c381c).
Report is 11 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (ed14f7f) and HEAD (c5c381c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (ed14f7f) HEAD (c5c381c)
unittests 1 0
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10953      +/-   ##
==========================================
- Coverage   49.64%   40.24%   -9.41%     
==========================================
  Files         178      161      -17     
  Lines       14801    14310     -491     
==========================================
- Hits         7348     5759    -1589     
- Misses       6105     7364    +1259     
+ Partials     1348     1187     -161     
Flag Coverage Δ
e2etests 36.51% <100.00%> (-9.46%) ⬇️
inttests 19.72% <0.00%> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian requested a review from a team September 28, 2024 04:03
@cwayne18
Copy link
Member

cwayne18 commented Oct 1, 2024

/trivy

1 similar comment
@cwayne18
Copy link
Member

cwayne18 commented Oct 1, 2024

/trivy

Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Trivy scan action failed, check logs ❌

@cwayne18
Copy link
Member

cwayne18 commented Oct 1, 2024

/trivy

Copy link
Contributor

github-actions bot commented Oct 1, 2024


bin/cni (gobinary)
==================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬───────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                           Title                           │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.22.6            │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│         │                │          │        │                   │                │ which contains deeply nested structures...                │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴───────────────────────────────────────────────────────────┘

bin/containerd-shim-runc-v2 (gobinary)
======================================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬───────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                           Title                           │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.22.6            │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│         │                │          │        │                   │                │ which contains deeply nested structures...                │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴───────────────────────────────────────────────────────────┘

bin/k3s (gobinary)
==================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬───────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                           Title                           │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.22.6            │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│         │                │          │        │                   │                │ which contains deeply nested structures...                │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴───────────────────────────────────────────────────────────┘

bin/runc (gobinary)
===================
Total: 1 (HIGH: 1, CRITICAL: 0)

┌─────────┬────────────────┬──────────┬────────┬───────────────────┬────────────────┬───────────────────────────────────────────────────────────┐
│ Library │ Vulnerability  │ Severity │ Status │ Installed Version │ Fixed Version  │                           Title                           │
├─────────┼────────────────┼──────────┼────────┼───────────────────┼────────────────┼───────────────────────────────────────────────────────────┤
│ stdlib  │ CVE-2024-34156 │ HIGH     │ fixed  │ 1.22.6            │ 1.22.7, 1.23.1 │ encoding/gob: golang: Calling Decoder.Decode on a message │
│         │                │          │        │                   │                │ which contains deeply nested structures...                │
│         │                │          │        │                   │                │ https://avd.aquasec.com/nvd/cve-2024-34156                │
└─────────┴────────────────┴──────────┴────────┴───────────────────┴────────────────┴───────────────────────────────────────────────────────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants