Add e2e test which verifies traffic policies and firewall in services #10972
+611
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
addTestAdvanceFeatureServices
branch
2 times, most recently
from
fbabd3b to
bb73757
Compare
manuelbuil
changed the title
manuelbuil
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10972 +/- ##
==========================================
- Coverage 50.06% 44.10% -5.96%
==========================================
Files 178 178
Lines 14801 14814 +13
==========================================
- Hits 7410 6534 -876
- Misses 6044 7077 +1033
+ Partials 1347 1203 -144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manuelbuil
force-pushed
the
addTestAdvanceFeatureServices
branch
2 times, most recently
from
975da3f to
bc30eee
Compare
thomasferrandiz
previously approved these changes
Oct 4, 2024
manuelbuil
force-pushed
the
addTestAdvanceFeatureServices
branch
from
bc30eee to
2031570
Compare
VestigeJ
previously approved these changes
Oct 7, 2024
dereknola
requested changes
Oct 7, 2024
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
tests/e2e/svcpoliciesandfirewall/svcpoliciesandfirewall_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: manuelbuil <mbuil@suse.com>
manuelbuil
force-pushed
the
addTestAdvanceFeatureServices
branch
from
2031570 to
3be3ae2
Compare
dereknola
approved these changes
Oct 8, 2024
thomasferrandiz
approved these changes
Oct 9, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
New e2e test to verify services externaltrafficpolicy, internaltrafficpolicy and loadBalancerSourceRanges
Types of Changes
New e2e test
Verification
Run go test
Testing
Linked Issues
User-Facing Change
Further Comments