Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Bump Wharfie to v0.6.7 #10977

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #10971

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 2, 2024 21:03
@dereknola
Copy link
Member Author

AS we have now bumped Wharfie to v1.29, we cannot bump it in release-1.28 branches.

@dereknola dereknola closed this Oct 3, 2024
@brandond
Copy link
Member

brandond commented Oct 3, 2024

Hmm I don't think that should be the case, I suspect we just need to pin something that was unintentionally bumped by go mod tidy when you bumped the wharfie version. There shouldn't be anything unique to 1.29 that wharfie actually relies on.

@brandond
Copy link
Member

brandond commented Oct 3, 2024

Try adding a replace for github.com/google/cel-go => github.com/google/cel-go v0.16.1 to keep it from being bumped when you bump wharfie. It looks like that's what broke.

@brandond brandond reopened this Oct 3, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.33%. Comparing base (d24cf9e) to head (cd60740).
Report is 1 commits behind head on release-1.28.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #10977      +/-   ##
================================================
- Coverage         39.06%   35.33%   -3.73%     
================================================
  Files               179      162      -17     
  Lines             18567    14269    -4298     
================================================
- Hits               7253     5042    -2211     
+ Misses            10096     8229    -1867     
+ Partials           1218      998     -220     
Flag Coverage Δ
e2etests 35.33% <ø> (-8.10%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 4fc3864 into k3s-io:release-1.28 Oct 7, 2024
29 checks passed
@dereknola dereknola deleted the wharfie_128 branch October 9, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants