Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.31] Allow additional Rootless CopyUpDirs through K3S_ROOTLESS_COPYUPDIRS #11041

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #10386

Types of Changes

Verification

Testing

Linked Issues

#11006

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner October 9, 2024 21:11
…env variable (k3s-io#10386)

Signed-off-by: Ludo Stellingwerff <ludo.stellingwerff@gmail.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (efa2804) to head (7f4c719).
Report is 15 commits behind head on release-1.31.

Files with missing lines Patch % Lines
pkg/rootless/rootless.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (efa2804) and HEAD (7f4c719). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (efa2804) HEAD (7f4c719)
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.31   #11041      +/-   ##
================================================
- Coverage         49.82%   43.83%   -5.99%     
================================================
  Files               178      178              
  Lines             14777    14779       +2     
================================================
- Hits               7362     6479     -883     
- Misses             6080     7108    +1028     
+ Partials           1335     1192     -143     
Flag Coverage Δ
e2etests 36.17% <0.00%> (-9.85%) ⬇️
inttests 36.74% <0.00%> (+<0.01%) ⬆️
unittests 13.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 5159131 into k3s-io:release-1.31 Oct 10, 2024
29 checks passed
@dereknola dereknola deleted the rootless_copy_131 branch October 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants