Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Allow additional Rootless CopyUpDirs through K3S_ROOTLESS_COPYUPDIRS #11042

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #10386

Types of Changes

Verification

Testing

Linked Issues

#11009

User-Facing Change


Further Comments

…env variable (k3s-io#10386)

Signed-off-by: Ludo Stellingwerff <ludo.stellingwerff@gmail.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 9, 2024 21:15
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.35%. Comparing base (eac26ef) to head (e2ef2a4).
Report is 15 commits behind head on release-1.28.

Files with missing lines Patch % Lines
pkg/rootless/rootless.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (eac26ef) and HEAD (e2ef2a4). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (eac26ef) HEAD (e2ef2a4)
unittests 1 0
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28   #11042      +/-   ##
================================================
- Coverage         40.87%   35.35%   -5.53%     
================================================
  Files               179      162      -17     
  Lines             18567    14271    -4296     
================================================
- Hits               7589     5045    -2544     
+ Misses             9695     8244    -1451     
+ Partials           1283      982     -301     
Flag Coverage Δ
e2etests 35.35% <0.00%> (-10.53%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 914f1d9 into k3s-io:release-1.28 Oct 10, 2024
29 checks passed
@dereknola dereknola deleted the rootless_copy__1.28 branch October 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants