Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.29] Launch private registry with init #11046

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #10822

Types of Changes

Verification

Testing

Linked Issues

#10821

User-Facing Change


Further Comments

…leanup (k3s-io#10822)

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner October 9, 2024 21:17
@dereknola dereknola changed the title [Release-1.28] Launch private registry with init [Release-1.29] Launch private registry with init Oct 9, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.32%. Comparing base (9624098) to head (9fae26d).
Report is 2 commits behind head on release-1.29.

❗ There is a different number of reports uploaded between BASE (9624098) and HEAD (9fae26d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9624098) HEAD (9fae26d)
e2etests 7 6
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11046      +/-   ##
================================================
- Coverage         49.35%   43.32%   -6.03%     
================================================
  Files               178      178              
  Lines             14924    14924              
================================================
- Hits               7365     6466     -899     
- Misses             6207     7285    +1078     
+ Partials           1352     1173     -179     
Flag Coverage Δ
e2etests 36.13% <ø> (-9.92%) ⬇️
inttests 36.85% <ø> (-0.01%) ⬇️
unittests 13.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 8b9c6bc into k3s-io:release-1.29 Oct 10, 2024
29 checks passed
@dereknola dereknola deleted the priv_reg_129 branch October 11, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants