Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.29] Simplify svclb ds #11084

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

manuelbuil
Copy link
Contributor

Backport: #10954
Issue: #11081

Signed-off-by: manuelbuil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner October 11, 2024 09:28
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.62%. Comparing base (ab5ecb3) to head (03c2d73).
Report is 1 commits behind head on release-1.29.

Files with missing lines Patch % Lines
pkg/cloudprovider/servicelb.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.29   #11084      +/-   ##
================================================
- Coverage         49.53%   43.62%   -5.91%     
================================================
  Files               178      178              
  Lines             14939    14887      -52     
================================================
- Hits               7400     6495     -905     
- Misses             6183     7193    +1010     
+ Partials           1356     1199     -157     
Flag Coverage Δ
e2etests 36.43% <71.42%> (-9.70%) ⬇️
inttests 19.90% <0.00%> (-17.02%) ⬇️
unittests 13.48% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil merged commit 56a9685 into k3s-io:release-1.29 Oct 11, 2024
32 checks passed
@manuelbuil manuelbuil deleted the svclb129 branch October 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants