Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of wrapped subcommands when run with a path #11306

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Nov 12, 2024

Proposed Changes

Fix handling of wrapped subcommands when run with a path

#11237 fixed k3s kubectl --help and kubectl --help but not /usr/local/bin/k3s kubectl --help or /usr/local/bin/kubectl --help

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner November 12, 2024 21:13
@brandond brandond force-pushed the fix-mustfindstring-path branch from d1ebeaa to ab730c5 Compare November 12, 2024 21:14
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.64%. Comparing base (71fdc4a) to head (b7e951b).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (71fdc4a) and HEAD (b7e951b). Click for more details.

HEAD has 18 uploads less than BASE
Flag BASE (71fdc4a) HEAD (b7e951b)
inttests 11 0
e2etests 7 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11306       +/-   ##
===========================================
- Coverage   46.87%   13.64%   -33.23%     
===========================================
  Files         179      176        -3     
  Lines       18587    18513       -74     
===========================================
- Hits         8712     2527     -6185     
- Misses       8516    15684     +7168     
+ Partials     1359      302     -1057     
Flag Coverage Δ
e2etests ?
inttests ?
unittests 13.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0c29696 into k3s-io:master Nov 13, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants