-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix secrets-encrypt reencrypt timeout error #11385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11385 +/- ##
==========================================
- Coverage 47.16% 42.34% -4.82%
==========================================
Files 179 179
Lines 18600 18601 +1
==========================================
- Hits 8772 7877 -895
- Misses 8476 9518 +1042
+ Partials 1352 1206 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
approved these changes
Nov 28, 2024
manuelbuil
approved these changes
Nov 28, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Dec 9, 2024
* Add missing default OS for split server test Signed-off-by: Derek Nola <derek.nola@suse.com> * Launch go routine and return for k3s secrets-encrypt reencrypt Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Dec 9, 2024
* Add missing default OS for split server test Signed-off-by: Derek Nola <derek.nola@suse.com> * Launch go routine and return for k3s secrets-encrypt reencrypt Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Dec 9, 2024
* Add missing default OS for split server test Signed-off-by: Derek Nola <derek.nola@suse.com> * Launch go routine and return for k3s secrets-encrypt reencrypt Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
k3s secrets-encrypt reencrypt
, once thereencrypt-active
annotation has been written, run the actual secrets updates in a go routine, allowing the http statusOK response to return in the 10s window.Types of Changes
Verification
Either have a slow cluster, or use large secrets. Either way, you need to have reencryption take more than 10 seconds.
I used 1000, 100k size secrets on a single node and could hit the 10s limit (4vcpu, 4GB)
With this change,
k3s secrets-encrypt reencrypt
should return with no errors within 1-3 seconds.Testing
Linked Issues
#11384
User-Facing Change
Further Comments