systemd unit: make EnvironmentFile optional #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, k3s.service was failing when the EnvironmentFile does not exist: ``` Feb 02 17:17:30 suda-ws01 systemd[1]: k3s.service: Failed to load environment files: No such file or directory Feb 02 17:17:30 suda-ws01 systemd[1]: k3s.service: Failed to run 'start' task: No such file or directory Feb 02 17:17:30 suda-ws01 systemd[1]: k3s.service: Failed with result 'resources'. Feb 02 17:17:30 suda-ws01 systemd[1]: Failed to start Lightweight Kubernetes. ``` ref: https://unix.stackexchange.com/questions/404199/documentation-of-equals-minus-in-systemd-unit-files Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
brandond
approved these changes
Feb 2, 2021
dweomer
approved these changes
Feb 3, 2021
briandowns
approved these changes
Feb 3, 2021
|
@AkihiroSuda do you think we should also fix this in the install script? Not sure what your use case is; it probably matters less with the install script because it also creates the required .env file. |
I agree. Not necessary for the scripted installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Make
EnvironmentFileoptional.Previously,
k3s.servicewas failing when theEnvironmentFiledoes not exist:ref: https://unix.stackexchange.com/questions/404199/documentation-of-equals-minus-in-systemd-unit-files
Types of Changes
BugFix
Linked Issues
For #2923
Verification
systemctl status k3s.servicewithout/etc/systemd/system/k3s.service.env.