Improve handling of comounted cpu,cpuacct controllers #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix_rke2_689
branch
from
a3f9e52
to
075eedf
Compare
briandowns
reviewed
Feb 9, 2021
briandowns
reviewed
Feb 9, 2021
briandowns
reviewed
Feb 9, 2021
|
Thanks for swapping out the "ifs" for switches. So much cleaner. |
briandowns
approved these changes
Feb 9, 2021
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
erikwilson
approved these changes
Feb 10, 2021
|
I think this is good but would be nice to have a cgroup test matrix of some kind |
|
@erikwilson I agree. In one of our recent QA meetings we talked about coming up with a matrix cgroups, rootless, and selinux that we need to test against to cover things that we're frequently seeing regressions on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix handling of comounted v1 controllers.
As noted at rancher/rke2#689 (comment) the order of the comounted controllers in /proc/self/cgroup doesn't always match the order in /sys/fs/cgroup - but we can count on there being an alias in there for each controller that points to the comounted hierarchy.
Types of Changes
Verification
See linked issue
Linked Issues
#2924
rancher/rke2#689
Further Comments
Also tidied up the code that iterates across the controller lists to be more unified in variable naming, and added some comments explaining whats going on.