Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine-1.21] Add functions to separate ipv4 from ipv6 functions #3929

Merged

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Aug 27, 2021

Signed-off-by: Manuel Buil mbuil@suse.com

Proposed Changes

This PR adds two functions to discriminate ipv4 and ipv6 addresses. This will simplify our lives if we want to use dual-stack with cni plugins such as Calico which does not follow the kubernetes convention "cluster-cidr: $CIDR_ipv4,$CIDR_ipv6"

Types of Changes

New feature. Two new functions in a library

Verification

Linked Issues

User-Facing Change

NONE

Further Comments

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil requested a review from a team as a code owner August 27, 2021 17:09
@manuelbuil manuelbuil changed the title Add functions to separate ipv4 from ipv6 functions [backport engine-1.21] Add functions to separate ipv4 from ipv6 functions Aug 27, 2021
@brandond brandond changed the title [backport engine-1.21] Add functions to separate ipv4 from ipv6 functions [engine-1.21] Add functions to separate ipv4 from ipv6 functions Aug 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3929 (75d3e27) into engine-1.21 (ed5991f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           engine-1.21    #3929      +/-   ##
===============================================
- Coverage        11.58%   11.57%   -0.02%     
===============================================
  Files              136      136              
  Lines             8847     8855       +8     
===============================================
  Hits              1025     1025              
- Misses            7598     7606       +8     
  Partials           224      224              
Flag Coverage Δ
inttests 0.68% <0.00%> (-0.01%) ⬇️
unittests 11.22% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/net.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5991f...75d3e27. Read the comment docs.

@manuelbuil manuelbuil merged commit a4c8810 into k3s-io:engine-1.21 Aug 27, 2021
@manuelbuil manuelbuil deleted the dual-stack-funcitons_engine branch October 28, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants