Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22] Properly handle operation as init process #4088

Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Sep 27, 2021

Proposed Changes

Properly handle operation as init process. This includes both vacating the root cgroup on cgroupv2 systems, and reaping child processes since containerd doesn't clean up after its own shims.

This is a Go adaptation of the behavior proposed in #3237; we rejected doing this in shell and K3d has been using a workaround ever since.

Types of Changes

bugfix

Verification

  • Run K3s in Docker on a system with cgroup v2; note that it works
  • Note that there are no <defunct> processes inside the Docker container

Linked Issues

User-Facing Change

The K3s docker image now works on cgroup v2 systems, and properly reaps terminated containerd shim processes.

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner September 27, 2021 23:59
@brandond
Copy link
Member Author

brandond commented Sep 28, 2021

Failed on a CI flake.
E0928 06:16:23.627678 55 kubelet.go:1406] "Failed to start cAdvisor" err="inotify_init: too many open files"

@brandond brandond merged commit a09bcba into k3s-io:release-1.22 Sep 28, 2021
@brandond brandond deleted the fix_docker_cgroupv2_release-1.22 branch June 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants