Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.22] - (rke2 1870) etcd snapshot does x509 host name verification even when skip verify is true #4103

Merged

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Sep 28, 2021

Signed-off-by: Brian Downs brian.downs@gmail.com

Proposed Changes

Backport of rancher/rke2#1870

Types of Changes

Verification

Linked Issues

#4110

User-Facing Change


Further Comments

@briandowns briandowns requested a review from a team September 28, 2021 19:50
@briandowns briandowns self-assigned this Sep 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #4103 (f78bf9f) into release-1.22 (bdd597f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.22    #4103      +/-   ##
================================================
- Coverage         11.66%   11.66%   -0.01%     
================================================
  Files               134      134              
  Lines              9052     9056       +4     
================================================
  Hits               1056     1056              
- Misses             7770     7774       +4     
  Partials            226      226              
Flag Coverage Δ
inttests 0.68% <0.00%> (-0.01%) ⬇️
unittests 11.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/etcd/s3.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd597f...f78bf9f. Read the comment docs.

@briandowns briandowns force-pushed the release-1.22-backport-rke2-1870 branch from b33809d to a4da0ed Compare September 30, 2021 23:09
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns force-pushed the release-1.22-backport-rke2-1870 branch from a4da0ed to f78bf9f Compare October 4, 2021 17:18
@briandowns briandowns merged commit 737f722 into k3s-io:release-1.22 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants